Add error handling when unable to get config from cluster#577
Open
pbzona wants to merge 1 commit intocodefresh-io:masterfrom
Open
Add error handling when unable to get config from cluster#577pbzona wants to merge 1 commit intocodefresh-io:masterfrom
pbzona wants to merge 1 commit intocodefresh-io:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I ran into an error while trying to install the runner, so I figured I'd make a quick PR. What happened was this:
I tried to init a new runner per the instructions in the UI, and was met with this:
Not the most useful message, so I found that the CLI tries to load the kubeconfig from its path, then directly from the cluster, and doesn't fall back to anything else. I added an extra step to make this failure a bit more intuitive.
A side note - I didn't realize at first that the runner host would need to be configured for the cluster before initializing. After a second thinking about it, of course it would, but I didn't see this mentioned in the docs at all so you might consider adding a note about that in a "prerequisites" section or something. That would have been helpful in this situation as well.
Anyway, I hope this is helpful. I'm not deeply invested in the actual error text here, so feel free to make changes if you are interested in merging this :)